frnix_06/Francescos.Recipes.World
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactoring some Code and clean Code

Browse Source
This commit is contained in:
franc
2025-04-09 15:37:44 +02:00
parent d248ccb1db
commit 127a60b621
19 changed files with 132 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Francesco.Recipes.World/Repositories/Instruction/IInstructionRepository.cs
+1 -2
View File
@@ -1,7 +1,6 @@
namespace Francesco.Recipes.World.Repositories.Instruction
{
using Francesco.Recipes.World.Models.BackendModels.Instruction;
using Francesco.Recipes.World.Models.BackendModels.Recipe;
public interface IInstructionRepository
{
@@ -11,6 +10,6 @@
Task<List<Instruction>> GetInstructionsByRecipeIdAsync(Guid recipeId);
Task RemoveInstructionFromRecipeAsync(Recipe recipe, Guid instructionId);
Task RemoveInstructionFromRecipeAsync(Guid recipeId, Guid instructionId);
}
}
Francesco.Recipes.World/Repositories/Instruction/InstructionRepository.cs
+16 -13
View File
@@ -2,7 +2,6 @@
{
using Francesco.Recipes.World.Data;
using Francesco.Recipes.World.Models.BackendModels.Instruction;
using Francesco.Recipes.World.Models.BackendModels.Recipe;
using Francesco.Recipes.World.Repositories.Recipe;
using Microsoft.EntityFrameworkCore;
@@ -25,19 +24,19 @@
public async Task<Instruction> CreateInstructionToRecipeAsync(Guid recipeId, string description, int number)
{
var recipe = await _recipeRepository.GetRecipeAsync(recipeId);
var recipe = await _recipeRepository.GetRecipeAsync(recipeId);
if (string.IsNullOrWhiteSpace(description))
if (string.IsNullOrWhiteSpace(description))
{
throw new ArgumentException("Description cannot be empty", nameof(description));
}
if (number <= 0)
if (number <= 0)
{
throw new ArgumentOutOfRangeException(nameof(number), "Number must be greater than 0.");
}
var newInstruction = new Instruction
var newInstruction = new Instruction
{
Id = Guid.NewGuid(),
Description = description,
@@ -45,24 +44,28 @@
Recipe = recipe,
};
_context.Instructions.Add(newInstruction);
await _context.SaveChangesAsync();
_context.Instructions.Add(newInstruction);
await _context.SaveChangesAsync();
return newInstruction;
return newInstruction;
}
public async Task RemoveInstructionFromRecipeAsync(Recipe recipe, Guid instructionId)
public async Task RemoveInstructionFromRecipeAsync(Guid recipeId, Guid instructionId)
{
if (recipe == null)
var recipe = await _recipeRepository.GetRecipeAsync(recipeId);
if (recipe.Instructions == null || !recipe.Instructions.Any())
{
throw new ArgumentNullException(nameof(recipe));
await _context.Entry(recipe)
.Collection(r => r.Instructions)
.LoadAsync();
}
var instructionToRemove = recipe.Instructions.FirstOrDefault(i => i.Id == instructionId);
var instructionToRemove = recipe.Instructions?.FirstOrDefault(i => i.Id == instructionId);
if (instructionToRemove != null)
{
recipe.Instructions.Remove(instructionToRemove);
recipe.Instructions?.Remove(instructionToRemove);
await _context.SaveChangesAsync();
}
}